Feat/kms: call first version of KMS for reencrypt and decrypt #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMPORTANT: the decrypt call should be replaced in most cases by cmux It is still called in Governor example in fhevm repository. To make tests passing we keep it for now. In the future, it will be replaced by async decryption For this early first version of KMS this is acceptable.
leventdem
changed the title
feat() add ifThenElse to the stack
feat() Update gas prices for decrypt and rand
- we now run tests that requires decryption using a local decryption instead of calling the kms - tests that necessarily require a kms to be live were disabled for now
youben11
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call KMS for two purposes: